42CTF/website
42CTF
/
website
13
5
Fork 10
Code Issues 10 Pull Requests 1 Projects 9 Releases Wiki Activity

Separate profile page for events #69

Merged
Danhia merged 2 commits from Danhia/website:event/fix-chall-slug into main 2023-02-05 23:13:44 +01:00
Conversation 4 Commits 2 Files Changed 2 +168 -2
Danhia commented 2022-08-16 18:08:54 +02:00
Owner
Copy Link

Hopefully this is all that still needs to be done to solve issue 42CTF/website#23

Hopefully this is all that still needs to be done to solve issue [42CTF/website#23](https://gitea.42ctf.org/42CTF/website/issues/23)
Danhia added 1 commit 2022-08-16 18:08:54 +02:00
Danhia requested review from Starthur 2022-08-16 18:09:12 +02:00
Danhia added the
bug
 label 2022-08-17 15:12:08 +02:00
Danhia commented 2022-09-04 20:34:04 +02:00
Author
Owner
Copy Link

@Starthur are you going to review some day ? 👀

@Starthur are you going to review some day ? 👀
🚀 1
Starthur added 1 commit 2022-10-13 20:23:23 +02:00
Starthur approved these changes 2022-10-13 20:25:41 +02:00
Starthur left a comment
Owner
Copy Link

Good job !

Good job !
src/events/templates/events/profile.html
@ -0,0 +29,4 @@
{% for s in solves %}
<tr>
<th scope="row"><a href="{% url 'events:event_chall_info' event_slug=event.slug chall_slug=s.ctf.slug %}">{{ s.ctf.name }}</a></th>
<td>{{ s.ctf.category.name}}</td>
Starthur commented 2022-10-13 20:24:42 +02:00
Owner
Copy Link

miss a space before }}

miss a space before `}}`
Starthur marked this conversation as resolved
Starthur commented 2022-10-21 13:46:28 +02:00
Owner
Copy Link

@Danhia I ping for two reason:

  1. This PR has been review for one week
  2. I want to test mail notification
@Danhia I ping for two reason: 1. This PR has been review for one week 2. I want to test mail notification
Starthur commented 2022-10-21 19:56:46 +02:00
Owner
Copy Link

@Danhia Ping de restest encore ! J'aime ça :D

@Danhia Ping de restest encore ! J'aime ça :D
Starthur commented 2023-01-30 20:28:04 +01:00
Owner
Copy Link

@Starthur are you going to review some day ? 👀

@Danhia are you going to merge some day ? 👀

> @Starthur are you going to review some day ? 👀 @Danhia are you going to merge some day ? 👀
Danhia merged commit 9d0a420cac into main 2023-02-05 23:13:44 +01:00
Danhia deleted branch event/fix-chall-slug 2023-02-05 23:13:44 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Starthur
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
translations

Translations problem

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 42CTF/website#69
No description provided.
Delete Branch "Danhia/website:event/fix-chall-slug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?