42CTF/website
42CTF
/
website
13
5
Fork 10
Code Issues 10 Pull Requests 1 Projects 9 Releases Wiki Activity

Scoreboard for 42 Network #73

Merged
Danhia merged 2 commits from Danhia/website:scoreboard/42network into main 2022-08-17 22:59:40 +02:00
Conversation 0 Commits 2 Files Changed 4 +57 -9
Danhia commented 2022-08-17 13:02:43 +02:00
Owner
Copy Link

Added a scoreboard that ranks all the campuses of the 42 Network.
It takes into account the top 10 players of all campuses, to keep it fair for the small campuses.

This partially implements 42CTF/website#15.

Added a scoreboard that ranks all the campuses of the 42 Network. It takes into account the top 10 players of all campuses, to keep it fair for the small campuses. This partially implements 42CTF/website#15.
Danhia added the
enhancement
 label 2022-08-17 13:02:43 +02:00
Danhia added 1 commit 2022-08-17 13:02:43 +02:00
Danhia requested review from ix 2022-08-17 13:02:53 +02:00
Danhia added this to the New features project 2022-08-17 15:12:50 +02:00
ix requested changes 2022-08-17 16:57:03 +02:00
ix left a comment
Member
Copy Link

Need to remove the pagination div and it's done.

Need to remove the pagination div and it's done.
src/scoreboard/templates/scoreboard/network.html
@ -0,0 +25,4 @@
</tbody>
</table>
<div class="pagination">
ix commented 2022-08-17 16:56:29 +02:00
Member
Copy Link

You can remove all the pagination div, you don't use it in the network view.

You can remove all the pagination div, you don't use it in the network view.
Danhia commented 2022-08-17 22:59:28 +02:00
Author
Owner
Copy Link

Done here

Done [here](https://gitea.42ctf.org/42CTF/website/commit/d21915405ed11e7006bd32104e785f33ed5dc614)
Danhia marked this conversation as resolved
Danhia added 1 commit 2022-08-17 22:58:40 +02:00
Danhia merged commit 7cd43ca35f into main 2022-08-17 22:59:40 +02:00
Danhia deleted branch scoreboard/42network 2022-08-17 22:59:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ix
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
translations

Translations problem

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
New features
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 42CTF/website#73
No description provided.
Delete Branch "Danhia/website:scoreboard/42network"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?