42CTF/website
42CTF
/
website
13
5
Fork 10
Code Issues 10 Pull Requests 1 Projects 9 Releases Wiki Activity

Fix member conversion page UI and SEO upgrades #75

Merged
Danhia merged 4 commits from ix/website:main into main 2022-08-18 14:21:13 +02:00
Conversation 0 Commits 4 Files Changed 26 +177 -52
ix commented 2022-08-18 13:47:24 +02:00
Member
Copy Link
- 42CTF/website#72 solved - 42CTF/website#36 partialy solved, need to rework metas - Fixed some UI, adding h1 and redesigned a bit page titles
ix added 2 commits 2022-08-18 13:47:25 +02:00
ix changed title from main to WIP: main 2022-08-18 13:47:40 +02:00
ix requested review from Danhia 2022-08-18 13:47:50 +02:00
ix changed title from WIP: main to main 2022-08-18 13:47:56 +02:00
ix changed title from main to Fix member conversion page UI and SEO upgrades 2022-08-18 13:52:23 +02:00
Danhia requested changes 2022-08-18 13:56:23 +02:00
src/templates/base.html Outdated
@ -29,6 +29,8 @@
<meta property="twitter:description" content="42CTF is a cybersecurity challenges platform created by School 42 students.">
<meta property="twitter:image" content="{% static "img/42ctf_logo.png" %}">
<link rel="canonical" href="https://www.example.com{{ request.path }}">
Danhia commented 2022-08-18 13:56:17 +02:00
Owner
Copy Link

Well I don't know much about SEO but I'm not sure for the example.com thing

Well I don't know much about SEO but I'm not sure for the `example.com` thing
Danhia added the
enhancement
 label 2022-08-18 13:57:22 +02:00
ix added 1 commit 2022-08-18 14:17:48 +02:00
ix requested review from Danhia 2022-08-18 14:18:41 +02:00
Danhia approved these changes 2022-08-18 14:19:53 +02:00
Danhia left a comment
Owner
Copy Link

Should be good for now

Should be good for now
Danhia added 1 commit 2022-08-18 14:20:45 +02:00
Danhia merged commit 13895d7712 into main 2022-08-18 14:21:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Danhia
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
translations

Translations problem

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 42CTF/website#75
No description provided.
Delete Branch "ix/website:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?