42CTF/website
42CTF
/
website
13
5
Fork 10
Code Issues 10 Pull Requests 1 Projects 9 Releases Wiki Activity

Rephrase a bit the become member page + improved french translation for resources #71

Merged
Danhia merged 1 commits from Danhia/website:resources/fix-typos into main 2022-08-16 22:37:00 +02:00
Conversation 0 Commits 1 Files Changed 15 +3025 -2633
Danhia commented 2022-08-16 19:48:47 +02:00
Owner
Copy Link

Well everything is in the title I guess

Well everything is in the title I guess
Danhia added the
enhancement
translations
 labels 2022-08-16 19:48:47 +02:00
Danhia added 1 commit 2022-08-16 19:48:48 +02:00
Danhia requested review from ix 2022-08-16 19:49:53 +02:00
ix requested changes 2022-08-16 20:05:46 +02:00
ix left a comment
Member
Copy Link

un seul petit soucis avec les 2 phrases ajoutées dans le become-member, solutions :

  • Merge les 2 nouvelles phrases et si ca ne suffit pas, réduire la taille du logo 42ctf
  • Supprimer le logo 42CTF
un seul petit soucis avec les 2 phrases ajoutées dans le become-member, solutions : - Merge les 2 nouvelles phrases et si ca ne suffit pas, réduire la taille du logo 42ctf - Supprimer le logo 42CTF
src/resources/templates/resources/becomeMember.html
@ -18,1 +18,3 @@
{% trans "42CTF is a non-profit organization with a legal status under the french law (Association loi 1901)." %}
{% blocktranslate %}
42CTF is a non-profit organization with a legal status under the french law (Association loi 1901).<br>
Running a CTF platform costs money, and we are not currently funded by anyone except you.<br>
ix commented 2022-08-16 20:00:52 +02:00
Member
Copy Link

Avec ces 2 phrases en plus, cela rend la page moins cohérente, il faudrait enlever une ligne ou à la limite merge les 2 ajoutées (regarde le résultat tu comprendra, normalement).

Avec ces 2 phrases en plus, cela rend la page moins cohérente, il faudrait enlever une ligne ou à la limite merge les 2 ajoutées (regarde le résultat tu comprendra, normalement).
Danhia marked this conversation as resolved
Danhia requested review from ix 2022-08-16 20:11:51 +02:00
ix approved these changes 2022-08-16 21:00:32 +02:00
Danhia merged commit e36ca2b146 into main 2022-08-16 22:37:00 +02:00
Danhia deleted branch resources/fix-typos 2022-08-16 22:37:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ix
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
translations

Translations problem

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 42CTF/website#71
No description provided.
Delete Branch "Danhia/website:resources/fix-typos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?